Extended functionality and polished ouput

nexxai / CryptoBlocker

A script to deploy File Server Resource Manager and associated scripts to block infected users

GNU General Public License v2.0

200 stars 73 forks source link

Extended functionality and polished ouput #5

Closed andi-blafasl closed 7 years ago

andi-blafasl commented 7 years ago

Hi nexxai, I really like your script! For my usage I have made some changes that may be useful for other users, too.

moved the user configuration to top of script
added notification messages to the template
removed notification messages from the file screen
added active/passiv screen type configuration
added german translation to the notification messages
output polished a bit ;-)
added a few more comments

Maybe you like some of the changes and integrate them in your version.

Best regards and keep up the nice work! Andreas

nexxai commented 7 years ago

Hi Andi,

I actually like most of these changes but just have a few very minor requests before I merge it into the main script:

Being that our userbase primarily speaks English, I'd really prefer if the default language is English with the option to enable German for those who prefer it.
I've heard from several people that they prefer "Active" vs. "Passive" so if that could be set as the default (again, with the option of switching to Passive if the person prefers), that would be great

If you can update your PR with those two small things, I'll merge them ASAP.

Thanks for your contributions!

andi-blafasl commented 7 years ago

Thank you for your fast reply! I will change the default language to English. Just forgot the change this prior to the pull request. For the Active/Passive thing, I think it would be best to have the default the to Passive. With this default, the admin can deploy the rules and test the setup in a production environment without interrupting the Users if anything goes wrong. How do you think about this?

nexxai commented 7 years ago

The issue with the Active/Passive thing is that if someone changes it to Active (to be more aggressive with their protection) and then re-syncs with GitHub to get the latest copy of the script, it's going to overwrite that preference and leave them less protected than they thought they were. I really don't want to put someone in a position where they have less security than they think they do.

Thoughts?

andi-blafasl commented 7 years ago

ok, good reason to set the default to active!

I committed the changes to my repo.