nexxtway / react-rainbow

🌈 React Rainbow Components. Build your web application in a snap.
https://react-rainbow.io
MIT License
1.79k stars 112 forks source link

feat: adding border radius prop to import record flow #2595

Closed adrianestevez1 closed 1 year ago

adrianestevez1 commented 1 year ago

fix: #

Changes proposed in this PR:

-adding border radius prop to ImportRecordFlow component

@nexxtway/react-rainbow

commit-lint[bot] commented 1 year ago

Features

Bug Fixes

Contributors

LeandroTorresSicilia

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 3b57963):

https://react-rainbow--pr2595-add-border-radius-im-prd5uan7.web.app

(expires Thu, 16 Feb 2023 18:49:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

TahimiLeonBravo commented 1 year ago

@adrianestevez1 let's add a new example with the different values for the borderRdius prop can have. I will share the design for the example with you. ;)

TahimiLeonBravo commented 1 year ago

@adrianestevez1 I think you forgot to change the borderRadius on some components:

Screenshot 2023-02-03 at 9 15 37 AM
codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 3b579635 and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 14

View more on Code Climate.