search

nexylan / graylog-rabbitmq

MIT License
6 stars 5 forks source link

Updated to reflect RMQ message model #13

Open mjtice opened 4 years ago

mjtice commented 4 years ago

Related to https://github.com/nexylan/graylog-rabbitmq/issues/12, essentially this PR modifies the way messages are published into RMQ. The "official" model for publishing messages is that:

The core idea in the messaging model in RabbitMQ is that the producer never sends any messages directly to a queue. [1]

So I've modified the config to: a. specify a vhost b. specify an exchange vs. a queue.

This will allow publishing to a non-default vhost into an exchange. If the exchange doesn't exist one will be declared (direct, durable).

  1. https://www.rabbitmq.com/tutorials/tutorial-three-java.html
romansavrulin commented 3 years ago

Hi! thanks for bringing this in! Can you update build instructions for getting your MR work with 3.2?

mjtice commented 3 years ago

Hey @romansavrulin I'm not sure I follow. Is this something in the pom.xml I need to update?

romansavrulin commented 3 years ago

@mjtice Looks like I've used the wrong word =)) I mean instructions. Anyway I've already found steps to build 2.0 and trying your MR in production.

Thanks for your effort, once again!