soc-pe-bot
commented
11 months ago Team's Response
We already have a warning present in the UG that discourages the use of edit command to add or remove tags.
We will consider adding further warning when a user tried to add/ remove a tag using the edit command as a further re-iteration of our existing warning in the user guide mentioned above.
Quoting the website: "In general, a flaw (e.g., a missing feature, a suboptimal design of a feature, a known bug) can be considered NotInScope if rectifying it is less important (based on the value/effort considerations)", therefore we categorise this as a NotInScope.
However, we do still believe that there are some use cases for allowing the edit command to add and remove tags. Suppose a HR Manager added the tag "intern", but wanted to add the tag "Intern" instead. Using the edit <INDEX> t/Intern, you can do both the add and remove tag functions in a single command, making it a powerful tool for experience users.
Given that a warning exist already in the UG, we anticipate that the likelihood of a user using the edit command to add/remove tags, and having a typo resulting in data loss to be rare. Therefore, we will choose to downgrade the severity of the flaw to low.
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I do understand that since you have mentioned it in the UG, you believe that the resulting data loss is rare. While acknowledging the presence of a note, it is important to recognize that users may overlook or miss this information. Without a warning during the actual operation, users, regardless of their experience level, may unintentionally trigger this behavior, disrupting their workflow. This can result in a loss of data. I believe at least a warning message should have been implemented. In the case that this does happen, a tag can accidentally be removed from a person without the user even noticing it. In the following tag-related operations, like when we want to find all people with a specific tag, people affected by an accidental tag edit may no longer be visible in the list and may miss out on things like important information dissemination in the context of an office, which could be extremely costly. The potential impact within an office setting, where accurate tagging is crucial, can have significant repercussions. This risk extends beyond minor inconvenience and aligns more closely with the impact associated with severity medium. Hence I do understand why you are inclined towards labelling this as severity.Low. However, I believe that the inconvenience of this is definitely not minor, especially since there is no way to undo and retrieve lost tags.
When I use the edit function on a person with two tags, and only input one t/ to edit, both the tags get removed and is replaced by just that one tag. This seems dangerous at there is nothing to prevent accidentally deleting a tag, causing loss of data. Consider implementing a warning rather than just mentioning