neynarxyz / explorer

A developer-focused farcaster explorer
https://explorer-neynar.vercel.app
8 stars 4 forks source link

username isn't found for a fid route #24

Open MrKevinOConnell opened 2 months ago

MrKevinOConnell commented 2 months ago

original cast: https://warpcast.com/behkod.eth/0x249d7695

Neynar explorer under "Example FID" is redirecting to wrong user. Its treating FID as a username. [Dan's FID is going to user @\3]

Steps to reproduce: 1.) - Go to e.g. explorer.neynar.com/3 [link below]

hints to solve: 1.) go to /src/app/[identifier] 2.) this line is incorrect for both supercast and warpcast:

                    authorFidCast
                      ? `https://www.supercast.xyz/c/${castHash}`
                      : `https://www.supercast.xyz/${username}`
                  }
behkod commented 2 months ago

Hey @MrKevinOConnell ,

Thanks for creating the issue.

But unfortunately it's not just this.

AFAICT there's a problem w/ the search as follows:

When you search for an FID that there's a corresponding username for it, The Warpcast API, Hoyt & Neynar Hub are giving it (search token as a username) a higher precedence over the token as an FID. And only the Neynar API works as presumed (Searching only on FID fields).

For example: If you're searching for 3 in the search field, those three will return data related to the "fid": 1754 & not dwr.eth, thus the pop-ups for those three under renderHeader will show data for fid=1754 [as follow:] neynex