search

neynarxyz / nodejs-sdk

Typescript SDK for Neynar APIs
https://neynar.com
MIT License
53 stars 11 forks source link

fix: notification type enums for input and output #154

Closed valerierose closed 2 months ago

valerierose commented 2 months ago

This PR reverts a breaking change that caused a bug in the SDK.

The strings used for notification type are different for inputs (all plural) and outputs (mention and reply are singular). A previous change used only the version for inputs, causing a breaking change. This PR fixes that issue by separating the two enums.

The corresponding change to the OAS is here.

Shreyaschorge commented 2 months ago

@valerierose Will you please create a new enum here and export it. src/neynar-api/common/constants.ts

Shreyaschorge commented 2 months ago

@valerierose Will you please create a new enum here and export it. src/neynar-api/common/constants.ts

I think NotificationType would be a good name