search

neynarxyz / nodejs-sdk

Typescript SDK for Neynar APIs
https://neynar.com
MIT License
53 stars 11 forks source link

moderatorFids is missing from Channel type. #179

Closed porenes closed 1 month ago

porenes commented 1 month ago

Channel infos now include moderatorFids: number[] , the type needs to be updated

https://github.com/neynarxyz/nodejs-sdk/blob/bec2e51dc436e81be9ca47e5922d41d184ffa09e/src/neynar-api/v2/openapi-farcaster/models/channel.ts#L28

Shreyaschorge commented 1 month ago

Channel infos now include moderatorFids: number[] , the type needs to be updated

https://github.com/neynarxyz/nodejs-sdk/blob/bec2e51dc436e81be9ca47e5922d41d184ffa09e/src/neynar-api/v2/openapi-farcaster/models/channel.ts#L28

@porenes Yeah we are working on it, it should be out in a couple of hours

porenes commented 1 month ago

You rock !

Shreyaschorge commented 1 month ago

@porenes are you using moderatorFids anywhere in anyway? Actually, a bug was introduced that the moderatorFids should have been snake_case but now it's camelCase. I just want to gauge whether we can make a breaking change. If so, this release will need to be put on hold. Sorry for the wait.

porenes commented 1 month ago

It's not live yet, I am using it in my code to support the new channel model. As I am using the SDK, I used a ts-expect-error, I assume that however the api is snake_case the Typescript type will use camelCase

Shreyaschorge commented 1 month ago

It'll be a breaking change in api since this API returns it as a camelCase. Will discuss it with the team and let you know.

Shreyaschorge commented 1 month ago

@porenes

This should fix it. Please use snake_case. https://github.com/neynarxyz/nodejs-sdk/pull/187