nezticle / qtcompress

Public API for QZip
Other
27 stars 10 forks source link

Weird while loop #4

Open GabrielRavier opened 5 years ago

GabrielRavier commented 5 years ago

Hello,

The condition at https://github.com/nezticle/qtcompress/blob/23f8831826cd72aedf99fc3699148b6c994fd677/src/compress/qzip.cpp#L644 is always true, because the variable at https://github.com/nezticle/qtcompress/blob/23f8831826cd72aedf99fc3699148b6c994fd677/src/compress/qzip.cpp#L641 is never changed.

If this is intentional, this should be documented. If this is not, this is probably a bug and should be fixed.

GabrielRavier commented 5 years ago

Note : This was originally reported to https://github.com/Stellarium/stellarium/issues/597