Closed tillenglert closed 1 year ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 75a497b
+| ✅ 152 tests passed |+
#| ❔ 3 tests were ignored |#
!| ❗ 2 tests had warnings |!
Curiously with -profile test
the DADA2 QC plots are broken but with -profile test_single
they are fine. Needs to be investigated and fixed eventually!
https://github.com/tillenglert/ampliseq/blob/b193c0f2cddde67d4759662cb269c8c521916b52/assets/report_template.Rmd#L194 https://github.com/tillenglert/ampliseq/blob/b193c0f2cddde67d4759662cb269c8c521916b52/assets/report_template.Rmd#L195
These lines will cause issues after merging with dev (input
needs to be changed to DADA2_input
) corresponding to PR: https://github.com/nf-core/ampliseq/pull/569
Now we should have all elements until and including taxonomic assignment in an ok-ish state. However, multiple testing runs need to be addressed in some way, profile test_multi can be the test case here.
https://github.com/BioContainers/multi-package-containers/pull/2663 The corresponding bio container should be created soon
From my side almost all done, only add
Should only take one more coding session.
edit: the failing linting is only template update 2.9, no other issues as far as I can see.
Regarding the report: Looks good! Two general comments:
Thanks for the review @WackerO ! About your general comments:
This PR adds a report module to the nf-core/ampliseq Pipeline. The report should include short text snippets for each module and either graphs or tables depicting the output of the corresponding tool.
The report is written in Rmarkdown and is generated using an external R script using a template .Rmd file. It is still work in progress, as I first wrote everything to be working on the results directory. Currently I'm adding each individual file which is used in the report to the input of the module, R script and into the template.
This draft PR should also enable @d4straub to help me when he has some time.
(Second PR as the first one was a bit messy.)
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).