Closed jtangrot closed 1 year ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit c6b8348
+| ✅ 157 tests passed |+
#| ❔ 1 tests were ignored |#
!| ❗ 2 tests had warnings |!
This PR addresses issue #574
The pacbio_its test probably fails due to out of memory in the assignTaxonomy step. I could either specify unite-fungi=8.3 in the test config, or instead try to increase max_memory in the config file. Which option is preferred?
However, I cannot make unite-fungi 9.0 work with qiime (unite-alleuk 9.0 works fine), so I skipped that one for now in the interest of having updated UNITE databases for assignTaxonomy and sintax.
agreed edit: actually, why not add unite-fungi 9.0 for QIIME as well but skip sh files (if thats the problem)
I could either specify unite-fungi=8.3 in the test config, or instead try to increase max_memory in the config file. Which option is preferred?
better use unite-fungi=8.3
, we do not want to mess with nf-core max resource settings, might lead to more problems.
However, I cannot make unite-fungi 9.0 work with qiime (unite-alleuk 9.0 works fine), so I skipped that one for now in the interest of having updated UNITE databases for assignTaxonomy and sintax.
agreed edit: actually, why not add unite-fungi 9.0 for QIIME as well but skip sh files (if thats the problem)
No, the sh files are not the problem, those are only used together with / after assignTaxonomy. It's the qiime formatted database that misbehaves in some way ("this classifier does not support confidence values"), or I am doing something wrong. Also see comment in issue 574.
I could either specify unite-fungi=8.3 in the test config, or instead try to increase max_memory in the config file. Which option is preferred?
better use unite-fungi=8.3, we do not want to mess with nf-core max resource settings, might lead to more problems.
OK, thanks!
Thanks!
UNITE databases are updated to version 9.0, and for qiime version 8.3 is also added. However, I cannot make unite-fungi 9.0 work with qiime (unite-alleuk 9.0 works fine), so I skipped that one for now in the interest of having updated UNITE databases for assignTaxonomy and sintax.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).