Closed d4straub closed 11 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 9742624
+| ✅ 158 tests passed |+
#| ❔ 3 tests were ignored |#
!| ❗ 2 tests had warnings |!
Current fails have two reasons:
(1) docker.io/biocontainers/biocontainers:v1.2.0_cv1 / https://www.docker.com/biocontainers/biocontainers:v1.2.0_cv1 isnt working with docker, singularity works though. That lets all tests fail that format reference taxonomy databases.
(2) .test.snap
doesnt match for test_reftaxcustom, test_qiimecustom, test_doubleprimers, test_novaseq: MultiQC version update changes multiQC md5sums, also CUSTOM_DUMPSOFTWAREVERSIONS version string changed with module update.
Ok, so the remaining issue in all failing tests is
Digest: sha256:3332df09060b4336e26929bb505a598d36137ad46eeb331dcb8846ca5776ca6c
Status: Downloaded newer image for biocontainers/biocontainers:v1.2.0_cv1
touch: cannot touch '.command.trace': Permission denied
for modules
NFCORE_AMPLISEQ:AMPLISEQ:FORMAT_TAXONOMY
NFCORE_AMPLISEQ:AMPLISEQ:SINTAX_TAXONOMY_WF:FORMAT_TAXONOMY_SINTAX
NFCORE_AMPLISEQ:AMPLISEQ:QIIME2_PREPTAX:FORMAT_TAXONOMY_QIIME
I assume the changes in nextflow.config produce the error, the entry docker.userEmulation = true
was removed and runOptions = '-u $(id -u):$(id -g)'
was added. Will need to test.
Container biocontainers/biocontainers:v1.2.0_cv1
was changed from 2.3.2 to 2.4.0 to 'ubuntu:20.04'. But biocontainers/biocontainers:v1.2.0_cv1
was needed, see https://github.com/nf-core/ampliseq/issues/502#issuecomment-1323365966, so the change was reverted back to biocontainers/biocontainers:v1.2.0_cv1
in https://github.com/nf-core/ampliseq/pull/503. The issue was that a container is needed that contains tar
, unzip
, and gunzip
(which isnt true for the ubuntu container).
Container issue related to https://github.com/nf-core/tools/pull/2607
Thanks!
This is for template update 2.11
As of the time of creating this PR there seems to be no conda package for that nf-core/tools version available yet so I cannot lint locally yet (i.e. stuff might go wrong).
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).