Closed Daniel-VM closed 4 months ago
nf-core lint
overall result: Passed :white_check_mark:Posted for pipeline commit a49930e
+| ✅ 196 tests passed |+
#| ❔ 4 tests were ignored |#
Indeed, the dev tag should be there. Usually there is a warning in nf-core lint
about the missing dev tag, probably we need to be a little more careful when looking at them ;)
Looking at the tests, why files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md ?
Indeed, the dev tag should be there. Usually there is a warning in
nf-core lint
about the missing dev tag, probably we need to be a little more careful when looking at them ;)
Absolutely 😅
Looking at the tests, why files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md ?
I thought nf-core/bacass didn't allow the -profile debug, but it actually does. So, this ignoring step aims to avoid nf-core linting errors while checking if those files differ from the TEMPLATE.
I am going to fix it in next PR.
files_unchanged
fixed here https://github.com/nf-core/bacass/pull/153 ;)
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).PR description
Just a PR fixing missing dev version by bumping 2.4.0dev.
I have realized that dev version 2.4.0 didn't carry the tag "dev" since it hasn't been released yet.