Closed SusiJo closed 3 years ago
Hi @SusiJo ,
thanks for the PR, I've added some comments. I did not see a clear reason so far for the failed tests but will investigate further.
@FriederikeHanssen could you also have a look at the PR whenever you have some time?
Looks great @SusiJo :) Thank you very much for contributing. If I am not mistaken, there is no test yet for the bai
, right? Would be great to add it just to be sure it works at all times. From my side we can merge now though and I add the test, when I make the stats stuff optional.
Many thanks to contributing to qbic-pipelines/bamtofastq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
testdata/
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md