nf-core / bamtofastq

Converts bam or cram files to fastq format and does quality control.
https://nf-co.re/bamtofastq
MIT License
21 stars 13 forks source link

Allow index files to be provided #21

Closed SusiJo closed 3 years ago

SusiJo commented 3 years ago

Many thanks to contributing to qbic-pipelines/bamtofastq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

Learn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md

ggabernet commented 3 years ago

Hi @SusiJo ,

thanks for the PR, I've added some comments. I did not see a clear reason so far for the failed tests but will investigate further.

ggabernet commented 3 years ago

@FriederikeHanssen could you also have a look at the PR whenever you have some time?

FriederikeHanssen commented 3 years ago

Looks great @SusiJo :) Thank you very much for contributing. If I am not mistaken, there is no test yet for the bai, right? Would be great to add it just to be sure it works at all times. From my side we can merge now though and I add the test, when I make the stats stuff optional.