nf-core / bamtofastq

Converts bam or cram files to fastq format and does quality control.
https://nf-co.re/bamtofastq
MIT License
21 stars 13 forks source link

Stats & some other minor changes #23

Closed FriederikeHanssen closed 3 years ago

FriederikeHanssen commented 3 years ago

Many thanks to contributing to qbic-pipelines/bamtofastq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

As discussed on slack, this pipeline can now be run without any stats computation. This should speed up the process. Additionally, some further minor changes were made: updated testate for index files, changed, and docs.

PR checklist

Learn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md

FriederikeHanssen commented 3 years ago

I am afraid the CI tests are not passing. as far as I see the reason is, that the test data is not merged yet, but I have updated the config already.

ggabernet commented 3 years ago

The bai for the tests are missing from the test data though

FriederikeHanssen commented 3 years ago

I see them here. They will be merged in now, which makes the tests fail right now :( Screenshot 2021-04-13 at 18 22 07