nf-core / bamtofastq

Converts bam or cram files to fastq format and does quality control.
https://nf-co.re/bamtofastq
MIT License
21 stars 13 forks source link

Porting pipeline to DSL2 #43

Closed SusiJo closed 1 year ago

SusiJo commented 1 year ago

Many thanks to contributing to qbic-pipelines/bamtofastq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

Learn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md

SusiJo commented 1 year ago

Hi @FriederikeHanssen, This is still a Draft PR so no need for a review yet. Since I had some branch issues on the other PR, I decided to make a fresh and cleaner PR. Also we decided to try integrating the pipeline into nf-core, therefore the labels have changed 😉

FriederikeHanssen commented 1 year ago

it would probably be good if we start merging PRs soon-ish to the dsl2, so we can fix things independently. Otherwise, I will have to push to your branch which will cause chaos :D

SusiJo commented 1 year ago

Linting is passing locally with nf-core tools 2.8.dev0. Might be failing because of a missing == in the pipeline template in the master branch that was added on the dev already. See here.