nf-core / bamtofastq

Converts bam or cram files to fastq format and does quality control.
https://nf-co.re/bamtofastq
MIT License
16 stars 13 forks source link

Add test yml files #45

Closed SusiJo closed 1 year ago

SusiJo commented 1 year ago

Many thanks to contributing to nf-core/bamtofastq!

PR checklist

Learn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md

maxulysse commented 1 year ago

Looking good. Only issue I see, is that test data appears not to be in https://github.com/nf-core/test-datasets

SusiJo commented 1 year ago

Should I copy the nf-core testdata that I used for the pipeline to the bamtofastq branch?

maxulysse commented 1 year ago

@SusiJo you still need to include the params you add in the test profile in the other profiles. The way we do it in sarek, is simply by doing -profile test,<other_test_profile>

SusiJo commented 1 year ago

@maxulysse since I removed the { includeConfig 'conf/test.config' } from the other test_profiles (test_chr.config , ...) it's not loading the maximal resource requirements from the test.config anymore and uses the base.config instead. Therefore the GHA are not running anymore. How can I still load the test.config for all the tests? I was following the sarek way of configuration, but it's not working. Am I missing something?

maxulysse commented 1 year ago

@maxulysse since I removed the { includeConfig 'conf/test.config' } from the other test_profiles (test_chr.config , ...) it's not loading the maximal resource requirements from the test.config anymore and uses the base.config instead. Therefore the GHA are not running anymore. How can I still load the test.config for all the tests? I was following the sarek way of configuration, but it's not working. Am I missing something?

The way we do it in sarek, is simply by doing -profile test,

What can probably try, is include both files in profiles