Closed SusiJo closed 1 year ago
Looking good. Only issue I see, is that test data appears not to be in https://github.com/nf-core/test-datasets
Should I copy the nf-core testdata that I used for the pipeline to the bamtofastq branch?
@SusiJo you still need to include the params you add in the test profile in the other profiles.
The way we do it in sarek, is simply by doing -profile test,<other_test_profile>
@maxulysse since I removed the { includeConfig 'conf/test.config' }
from the other test_profiles (test_chr.config
, ...) it's not loading the maximal resource requirements from the test.config
anymore and uses the base.config
instead. Therefore the GHA are not running anymore. How can I still load the test.config
for all the tests?
I was following the sarek way of configuration, but it's not working. Am I missing something?
@maxulysse since I removed the
{ includeConfig 'conf/test.config' }
from the other test_profiles (test_chr.config
, ...) it's not loading the maximal resource requirements from thetest.config
anymore and uses thebase.config
instead. Therefore the GHA are not running anymore. How can I still load thetest.config
for all the tests? I was following the sarek way of configuration, but it's not working. Am I missing something?The way we do it in sarek, is simply by doing -profile test,
What can probably try, is include both files in profiles
Many thanks to contributing to nf-core/bamtofastq!
PR checklist
testdata/
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md