Closed SusiJo closed 1 year ago
@sateeshperi & @maxulysse: Thanks for the review! I added the suggestions to the Code review PR. Is there anything else?
@maxulysse & @sateeshperi could anyone review at the PR #52 where I added your suggestions from here?
Thanks for the review @JoseEspinosa! I applied your suggestions in the PR #54. Could you take another look, please? 🙏
@JoseEspinosa : since you requested changes, is there anything else I should add to the current Code review PR #55 ?
@maxulysse Thanks for the review!
Approved by three, will merge #50 to master
Many thanks to contributing to qbic-pipelines/bamtofastq!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
PR checklist
testdata/
nextflow run . -profile test,docker
).nf-core lint .
).docs
is updatedCHANGELOG.md
is updatedREADME.md
is updatedLearn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md