nf-core / bamtofastq

Converts bam or cram files to fastq format and does quality control.
https://nf-co.re/bamtofastq
MIT License
16 stars 13 forks source link

Pseudo PR - Do not merge! #51

Closed SusiJo closed 1 year ago

SusiJo commented 1 year ago

Many thanks to contributing to qbic-pipelines/bamtofastq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

Learn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md

SusiJo commented 1 year ago

@sateeshperi & @maxulysse: Thanks for the review! I added the suggestions to the Code review PR. Is there anything else?

SusiJo commented 1 year ago

@maxulysse & @sateeshperi could anyone review at the PR #52 where I added your suggestions from here?

SusiJo commented 1 year ago

Thanks for the review @JoseEspinosa! I applied your suggestions in the PR #54. Could you take another look, please? 🙏

SusiJo commented 1 year ago

@JoseEspinosa : since you requested changes, is there anything else I should add to the current Code review PR #55 ?

SusiJo commented 1 year ago

@maxulysse Thanks for the review!

FriederikeHanssen commented 1 year ago

Approved by three, will merge #50 to master