nf-core / bamtofastq

Converts bam or cram files to fastq format and does quality control.
https://nf-co.re/bamtofastq
MIT License
16 stars 13 forks source link

Apply formatting changes from code review #58

Closed SusiJo closed 1 year ago

SusiJo commented 1 year ago

Many thanks to contributing to nf-core/bamtofastq!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

Learn more about contributing: https://github.com/qbic-pipelines/bamtofastq/tree/master/.github/CONTRIBUTING.md

SusiJo commented 1 year ago

Linting is expected to fail, because the Contributing.md differs from the pipeline template. However, the pipeline template of nf-core/tools version 2.8 is outdated as it lists a Dockerfile which should not be there anymore.

JoseEspinosa commented 1 year ago

Linting is expected to fail, because the Contributing.md differs from the pipeline template. However, the pipeline template of nf-core/tools version 2.8 is outdated as it lists a Dockerfile which should not be there anymore.

Adding this to the .nf-core.yml should do the trick:

lint:
  files_unchanged:
    - .github/CONTRIBUTING.md

See here

SusiJo commented 1 year ago

Thanks @JoseEspinosa!