Response to comments from Maxime on the upcoming release-PR.
Is the inclusion of (sub)workflows here before the calls to getGenomeAttribute a mistake? (Perhaps it doesn't matter, but in Sarek it is done the over way around.)
I guess we don't want to update the CHANGELOG for this kind of PR, right?
PR checklist
[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/bamtofastq branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).
Response to comments from Maxime on the upcoming release-PR.
Is the inclusion of (sub)workflows here before the calls to getGenomeAttribute a mistake? (Perhaps it doesn't matter, but in Sarek it is done the over way around.)
I guess we don't want to update the CHANGELOG for this kind of PR, right?
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).