search

nf-core / circdna

Pipeline for the identification of extrachromosomal circular DNA (ecDNA) from Circle-seq, WGS, and ATAC-seq data that were generated from cancer and other eukaryotic cells.
https://nf-co.re/circdna
MIT License
25 stars 14 forks source link

Latest default circdna version is 1.0.0 and not 1.0.1 #34

Closed madagiurgiu25 closed 1 year ago

madagiurgiu25 commented 1 year ago

Description of the bug

By default the latest version of circdna is 1.0.0 not 1.0.1. Could you please update the latest version tag? It might be confusing. Thank you.

nextflow pull nf-core/circdna
Checking nf-core/circdna ...
 done - revision: b0152a3629 [1.0.0]

nextflow.config contains the version 1.0dev :

manifest {
    name            = 'nf-core/circdna'
    author          = 'Daniel Schreyer'
    homePage        = 'https://github.com/nf-core/circdna'
    description     = 'Pipeline for the identification of circular DNAs'
    mainScript      = 'main.nf'
    nextflowVersion = '!>=21.10.3'
    version         = '1.0dev'
}

Command used and terminal output

No response

Relevant files

No response

System information

No response

DSchreyer commented 1 year ago

Hi, I cannot replicate the bug. When I perform nextflow pull nf-core/circdna, the latest version circdna version 1.0.1 is pulled. However, when version 1.0.0 is pulled, the manifest in the nextflow.config gives the confusing version 1.0dev, which can not be changed.

When did you pull nf-core/circdna?

My output:

nextflow pull nf-core/circdna
Checking nf-core/circdna ...
Fast-forward - revision: 8ff55299f1 [master]
madagiurgiu25 commented 1 year ago

Hi,

I pulled the nf-core/circdna on that day, so 24.09.2022.

I pulled now the repository:

nextflow pull nf-core/circdna
Checking nf-core/circdna ...
done - revision: 50681adaf7 [1.0.1]

manifest {
    name            = 'nf-core/circdna'
    author          = 'Daniel Schreyer'
    homePage        = 'https://github.com/nf-core/circdna'
    description     = 'Pipeline for the identification of circular DNAs'
    mainScript      = 'main.nf'
    nextflowVersion = '!>=21.10.3'
    version = '1.0.1'
}

And yes the latest version is 1.0.1 and also the nextflow.config manifest is updated. Thank you.