nf-core / configs

Config files used to define parameters specific to compute environments at different Institutions
https://nf-co.re/configs
MIT License
85 stars 265 forks source link

Add dummy configs for all missing configs #674

Closed jfy133 closed 5 months ago

jfy133 commented 5 months ago

This is for allowing us to uncomment out the part in the pipeline template.

I wonder if it just works 'as is' or if we have to add an explicit profile or not... ideas @maxulysse ?

jfy133 commented 5 months ago

Not tested because on train

mashehu commented 5 months ago

If you want I can write a github action which periodically checks https://nf-co.re/pipeline_names.json and creates that.

mashehu commented 5 months ago

One thing I find sub-optimal: we now have conf/pipeline/ and pipeline/. too easy to confuse the two, imo

maxulysse commented 5 months ago

One thing I find sub-optimal: we now have conf/pipeline/ and pipeline/. too easy to confuse the two, imo

both have different usage, but I see your point

mashehu commented 5 months ago

yes, different usage and same name is never good

jfy133 commented 5 months ago

If you want I can write a github action which periodically checks https://nf-co.re/pipeline_names.json and creates that.

That would be awesome

jfy133 commented 5 months ago

Should I wait for the GHA @mashehu before merging? But otherwise I will prepare the tools template to uncomment the relevant code, and update our new-project-guidance

mashehu commented 5 months ago

yes, I will add the GHA to this PR. Any chance we can use a different name than pipeline/ for the placeholders?

jfy133 commented 5 months ago

yes, I will add the GHA to this PR. Any chance we can use a different name than pipeline/ for the placeholders?

No I don't think so. It's already embedded in existing pipelines for a while, so if we changed it would break compatibility with old releases. @maxulysse correct me if I'm wrong

mashehu commented 5 months ago

okay, GHA is there. as usual need to really test it in production (I ran it locally with act and it looked fine, but we will see). Left some testing code in it, so we will need a clean-up PR after this one is merged and the workflow has been tested

jfy133 commented 5 months ago

Looks good to me @mashehu !

If you can both review: https://github.com/nf-core/tools/pull/2936/ and re-review this one, then i will merge this PR and shortly after the tools one