Open jpcartailler opened 6 months ago
nf-core lint
overall result: Failed :x:Posted for pipeline commit 028f027
+| ✅ 196 tests passed |+
#| ❔ 2 tests were ignored |#
!| ❗ 3 tests had warnings |!
-| ❌ 8 tests failed |-
Hi @jpcartailler, sorry for taking so long to get to this, I have been away on Paternity leave. Could you fix the tests and I can merge?
Thanks @chris-cheshire and no worries, being a dad is way more important.
I'm a little puzzled by the errors to be honest. I was just modifying two .md
files, but see errors related to the following:
[files_exist](https://nf-co.re/tools/docs/2.13/pipeline_lint_tests/files_exist) - File must be removed: lib/Utils.groovy
[files_exist](https://nf-co.re/tools/docs/2.13/pipeline_lint_tests/files_exist) - File must be removed: lib/WorkflowMain.groovy
[files_exist](https://nf-co.re/tools/docs/2.13/pipeline_lint_tests/files_exist) - File must be removed: lib/NfcoreTemplate.groovy
[files_exist](https://nf-co.re/tools/docs/2.13/pipeline_lint_tests/files_exist) - File must be removed: lib/WorkflowCutandrun.groovy
[files_unchanged](https://nf-co.re/tools/docs/2.13/pipeline_lint_tests/files_unchanged) - .github/workflows/branch.yml does not match the template
[files_unchanged](https://nf-co.re/tools/docs/2.13/pipeline_lint_tests/files_unchanged) - .github/workflows/linting_comment.yml does not match the template
[files_unchanged](https://nf-co.re/tools/docs/2.13/pipeline_lint_tests/files_unchanged) - .github/workflows/linting.yml does not match the template
[files_unchanged](https://nf-co.re/tools/docs/2.13/pipeline_lint_tests/files_unchanged) - pyproject.toml does not match the template
Any thoughts or guidance? TY
Damn i think I need to upgrade the pipeline to pass the new nf-core tools spec. Bear with me, I will update the pipeline and then you will need to pull from dev
Thanks @chris-cheshire - is there anything for me to try yet?
Not yet no, this needs quite a large update I am afraid. Nf-core have removed all the groovy libs in favour of plugins so its a substantial code change
Issue
<details markdown="1">
tag in the last working section (### 4.3
), but no closing tag.###6.5
starts, there is dangling closing tag</details>
Fix Move tag to appropriate location
PR checklist
docs/output.md
is updated.CHANGELOG.md
is updated