Closed glichtenstein closed 9 months ago
master
branch :x:base
to dev
Hi @glichtenstein,
It looks like this pull-request is has been made against the glichtenstein/demultiplex master
branch.
The master
branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master
are only allowed if they come from the glichtenstein/demultiplex dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit aa54803
+| ✅ 160 tests passed |+
#| ❔ 2 tests were ignored |#
!| ❗ 4 tests had warnings |!
I will work on this more, I still need to do more tests. I'm considering making that behaviour for skipping emtpy fastqs optional. Should I close the pull request or can I leave it as a draft? Thanks for the reviews.
I'd leave it as draft, so that everybody can see what the status is with this issue and maybe not start something else from scratch.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).