Closed WackerO closed 5 months ago
nf-core lint
overall result: Passed :white_check_mark:Posted for pipeline commit d62c163
+| ✅ 164 tests passed |+
I also think we should add something to the CSS to place 'contributor blocks' inline, so that we better use the horizontal space.
You mean so that the different blocks are next to each other? Let me see if I can figure something out
Yes, lots of contributors will use a lot of vertical space. We can fix it by making each contributor an inline div or having them float left, but it will take me a minute to figure out how to do it via the markdown. I can have a go at some point if you can't figure it out.
Alright, some changes later: The param --report_contacts_file
expects a single TXT file with all the PIs and authors and project managers and whatever. As it is, the TXT file in this zip will produce the report in the same zip:
all_bold.zip
Alternatively, I removed the asterisks from the RMD file and added them directly into the contacts file (see formatted zip). This allows users to add markdown symbols into their contacts to decide themselves how they want that section of the report to be formatted. I personally find this to be really cool (and as bold/italics can both be done with * characters, it is also fairly simple to use), but of course that would be the "advanced" version and I'm not sure if we should keep this as simple as possible and just print all contacts in bold. Thoughts? @pinin4fjords formatted.zip
Sorry, but I think this has just got over-complicated- now you have a new file format for the contributors to document and maintain for users, plus the parsing logic.
I suggest something much simpler. A set of parms with comma-separated values:
Again, don't assume PI, it only makes sense in academia
Sorry, but I think this has just got over-complicated- now you have a new file format for the contributors to document and maintain for users, plus the parsing logic.
I suggest something much simpler. A set of parms with comma-separated values:
* report_contributor_names * report_contributor_role (PI, postdoc, bioinformatics engineer) * report_contributor_affiliation
Again, don't assume PI, it only makes sense in academia
Done! As discussed, it is now only a single string param; contribs are separated by ;
, linebreaks are indicated by \n
Also, an example report with this please?
Also, an example report with this please?
Sure, here you go! SRP254919.html.zip
...and added newline between report author and workflow version. Example report with the new header is attached
SRP254919_contact.html.zip
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).