Closed alanmmobbs93 closed 4 days ago
nf-core pipelines lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit e7fd0b4
+| ✅ 300 tests passed |+
#| ❔ 6 tests were ignored |#
!| ❗ 4 tests had warnings |!
A lot of other changes here, do you need to sort out via Git?
@pinin4fjords Sorry about that, it's corrected now
Could you merge the latest changes from dev? I've incorporated some modifications to the ci.yml
, that should make your tests run :).
@pinin4fjords Done! I just added some comments to your solution to make it not only shorter but also readable. I cannot attach the output HTML files here, If you know how to do it just let me know. To my surprise, some genes were lost in the process when running the test_full profile
To my surprise, some genes were lost in the process when running the test_full profile
OK, if this is having an impact on results we'll need to spend some time figuring that out before any merge
Hello @pinin4fjords! I'd kindly suggest going on with this PR. This is a preexisting problem that got visualized now with these warnings (reinforcing the concept of always checking these steps). It's not about the new code as you can see with the following outputs:
Printing dim(diff)
on dev branch
## Dimensions of DIFF before merging
## 31317 4
## Dimensions of DIFF after merging
## 27743 6
Printing dim(diff)
on feature branch:
## Dimensions of DIFF before merging
## 31317 4
## Dimensions of DIFF after merging
## 27743 6
We can work on the issue after this
PR checklist
CHANGELOG.md
is updated.Issue reported:
On #340 it was reported that many genes were lost in the volcano plot generated by the R Markdown report, but that the PNG file was correct. These genes get lost if the annotation table doesn't contain them, resulting in reduced plots and results in this last part. As mentioned by the user, big discrepancies can be easily catched, but the small ones can go unnoticed, ending up in undesired results.
So, a warning message was added if the annotated differential expressed table contains fewer rows. Other solutions can be: