nf-core / eager

A fully reproducible and state-of-the-art ancient DNA analysis pipeline
https://nf-co.re/eager
MIT License
129 stars 78 forks source link

DSL2: fix print contamination output #1003

Closed scarlhoff closed 1 year ago

scarlhoff commented 1 year ago

Removed the meta from input and output for print_contamination module, so output of multiple samples is printed. This closes #1000. The output from print_contamination.py now prints "null" in the json and "None" in the txt output, as mentioned in #995. Downstream behaviour in MultiQC needs to be assessed in the future.

PR checklist

github-actions[bot] commented 1 year ago

This PR is against the master branch :x:


Hi @scarlhoff,

It looks like this pull-request is has been made against the scarlhoff/eager master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the scarlhoff/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!