nf-core / eager

A fully reproducible and state-of-the-art ancient DNA analysis pipeline
https://nf-co.re/eager
MIT License
143 stars 80 forks source link

Dsl1 2.5.0 #1021

Closed TCLamnidis closed 11 months ago

TCLamnidis commented 1 year ago

Closes #1020. Closes #1017. Clsoes #1031.

PR checklist

TCLamnidis commented 1 year ago

still need:

TCLamnidis commented 1 year ago

Citation is there already given it is already used for damage rescaling! https://github.com/nf-core/eager/blob/631f18efa4147d0b787245ed8dda041d00ebf6fd/README.md?plain=1#L249

TCLamnidis commented 1 year ago

Added mapDamage to Default Pipeline Steps in README. Standardised tool name to mapDamage across all docs (as the name is in the GH repository of the tool)

TCLamnidis commented 1 year ago

Will wait for mapdamage module to be added to multiqc, then should be ok to merge

jfy133 commented 12 months ago

Should add a big fat warning top of the readme sayi g maximum NDC aversion of 22.10.6

TCLamnidis commented 11 months ago

Regarding the Bowtie read groups, the suggested edits would also need to be propagated to the bwa job. Specifically:

TCLamnidis commented 11 months ago

TODO: MultiQC does not pick up the mapdamage outputs locally, even though they are correctly published within the work directory and the module is activated. Have to check what is wrong.

TCLamnidis commented 11 months ago

I think that's everything!

TCLamnidis commented 11 months ago

@ltcrod Please have a look at the RG information for the mappers. Let me know if anything would be better implemented differently.

TCLamnidis commented 11 months ago

Linting works with nf-core v1.14. only failures are about template matching.