nf-core / eager

A fully reproducible and state-of-the-art ancient DNA analysis pipeline
https://nf-co.re/eager
MIT License
143 stars 80 forks source link

Fix bedtools coverage in DSL1 #1036

Closed IdoBar closed 7 months ago

IdoBar commented 9 months ago

Remove the -sorted flag so bedtools won't assume that the reference genome file is sorted.

PR checklist

github-actions[bot] commented 9 months ago

This PR is against the master branch :x:


Hi @IdoBar,

It looks like this pull-request is has been made against the IdoBar/eager master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the IdoBar/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

TCLamnidis commented 9 months ago

Hi Ido!

Thanks for the PR. I will look into it and try to incorporate it into a patch release with a couple more small changes in the beginning of next year.

TCLamnidis commented 7 months ago

Had another look into why we added that flag #824 . It seems without it, the memory footprint of bedtools coverage is extremely large. I think I will instead add an option to REMOVE the -sorted flag.

TCLamnidis commented 7 months ago

Changes implemented in #1052 , so closing this PR. Thank you for the contribution!