Closed jfy133 closed 3 years ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit bcb5bec
+| β
366 tests passed |+
#| β 4 tests were ignored |#
!| β 33 tests had warnings |!
Only thoughts from me:
1) I don't particularly like the logo right-justified in the README 2) The logo looks a bit 'cut off' on the MultiQC report (as in the banner goes into nothing)
I think that it's especially illegible when small on the MultiQC report.. π
I know it was kind of the whole point, but what about just staying simple and using a white outline around text without the green background stripe? Maybe with bonus shadow if you want..
New version
Looks better now, but the outline might be too thick? Thoughts @ewels ?
I don't think the MultiQC report needs a DarkMode
Agreed but I only want to deal with a single logo file where possible. So this is the original logo but just with the outline (for both readme and MultiQC report)
I see. But as we already have a logo for multiQC in assets, it could be done to use 2 different logos depending of the needs.
But I agree, it's not really helping out
I think I'm using the same for both π€.
Either way I think this version at least it's overall more portable (even if a bit more boring, comparatively)
Sent from my mobile
On Fri, 28 May 2021, 15:31 Maxime U. Garcia, @.***> wrote:
I see. But as we already have a logo for multiQC in assets, it could be done to use 2 different logos depending of the needs.
But I agree, it's not really helping out
β You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nf-core/eager/pull/755#issuecomment-850421230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEI6MTZGKQDDY7IQP4OAPDLTP6LL7ANCNFSM45I7BHIA .
Looks good!
Another totally different idea - can we find a grey that works for both backgrounds instead of using black text?
To use the colour scheme from the Github website (for semi-consistency), almost a 'silver' grey
And then locking the two github background colours na dcycling through https://coolors.co/
Blue grey
Slightly red grey
Or bluey again
Honestly I think I prefer the black one...
unless you have another idea for a grey @ewels (e.g. if you were thinking darker)
I think Phil's idea was to use a gray that will work on both themes WITHOUT the white border, rather than what you have made here.
For my two cents, from the grays, blue/blueish greys look nicer than silver grey/redish grey. Though I too prefer the black one overall. I think that the dark-mode logo with black letters would actually look nicer with a thinner white border than the one you have here. enough to separate it from the background but not enough that it becomes a "noticable" to the point the logo feels like a different thing between light and dark mode.
Ah fair point. Even so finding a nicer grey was quite hard...
But yes can make the outline thinner. Seemed a bit too fat for me too.
This adds a new logo discussed on #graphics to try out improved dark mode compatibility.
If this style is adopted across other pipelines then I will rename everything back down to the template-like file names.
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).