nf-core / eager

A fully reproducible and state-of-the-art ancient DNA analysis pipeline
https://nf-co.re/eager
MIT License
148 stars 82 forks source link

Increase significance figures in general stats table #834

Closed neija2611 closed 1 year ago

neija2611 commented 2 years ago

When the mean coverage is below 0.05X, the general stats table only shows 0.0X For low coverage data an increase in significance would be helpful.

When mean coverage is 0.02495, I'd like to see 0.025X.

jfy133 commented 2 years ago

Hi @neija2611

Hmm, that's a good question. I will definitely list this for the next release, but this might be a while as I'm working on re-writing the pipeline into a new nextflow version.

in the meantime however, you can maybe

  1. make a custom multiqc config by copying the base eager one here: https://github.com/nf-core/eager/blob/master/assets/multiqc_config.yaml
  2. play around with the following parameters: https://multiqc.info/docs/#number-base-multiplier
  3. supply the file to your nextflow run command with --multiqc_config <your_custom_config>.conf

And see if that makes a difference you're looking for. If so, please let me know and I can implement it.

Cheers,

jfy133 commented 2 years ago

Ok, I was wrong with my original suggestions, but I think I may have a solution via: https://multiqc.info/docs/#command-line-config

EDIT: nope, that is for the multiqc-supported qualimap config

jfy133 commented 2 years ago

Essentially we want to tweak this

https://github.com/ewels/MultiQC/blob/75ef0ab9bbe33c24502be10c709ce374e736dbfe/multiqc/modules/qualimap/QM_BamQC.py#L549-L562

to include something like this

https://github.com/ewels/MultiQC/blob/75ef0ab9bbe33c24502be10c709ce374e736dbfe/multiqc/modules/qualimap/QM_BamQC.py#L537

But I don't think it makes sense to have that directly in MQC as most modern people won't have the issue of low-coverage data

jfy133 commented 2 years ago

@neija2611 this is going to be fixed by the MultiQC main dev ^1, so we will be able to add this once the next MultiQC release is out - but this wil ltake some time