nf-core / eager

A fully reproducible and state-of-the-art ancient DNA analysis pipeline
https://nf-co.re/eager
MIT License
140 stars 80 forks source link

Patch getsoftwareversions java tools #890

Closed jfy133 closed 2 years ago

jfy133 commented 2 years ago

To close #885

PR checklist

github-actions[bot] commented 2 years ago

This PR is against the master branch :x:


Hi @jfy133,

It looks like this pull-request is has been made against the nf-core/eager master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the nf-core/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions[bot] commented 2 years ago

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks. To fix this CI test, please run:

Once you push these changes the test should pass, and you can hide this comment :+1:

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

github-actions[bot] commented 2 years ago

YAML linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks. To fix this CI test, please run:

Once you push these changes the test should pass, and you can hide this comment :+1:

We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

maxibor commented 2 years ago

If the software_versions.csv file contains the correct software versions, that works for me ! (the get_software_versions process can not really fail)

jfy133 commented 2 years ago

[patch-getsoftwraeversions-java](/nf-core/eager/tree/patch-getsoftwraeversions-java)

Will double check

jfy133 commented 2 years ago

OK I'm having to update the eva config in tandem, and now mutlqic QC craps out. ugh

jfy133 commented 2 years ago

image

Proof it now works. Also in tandem with a config update: https://github.com/nf-core/configs/pull/382