Closed jfy133 closed 2 years ago
master
branch :x:base
to dev
Hi @jfy133,
It looks like this pull-request is has been made against the nf-core/eager master
branch.
The master
branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master
are only allowed if they come from the nf-core/eager dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
To keep the code consistent with lots of contributors, we run automated code consistency checks. To fix this CI test, please run:
markdownlint-cli
brew install markdownlint-cli
npm
then install markdownlint-cli
(npm install -g markdownlint-cli
)markdownlint . --config .github/markdownlint.yml --fix
markdownlint . --config .github/markdownlint.yml
Once you push these changes the test should pass, and you can hide this comment :+1:
We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!
Thanks again for your contribution!
To keep the code consistent with lots of contributors, we run automated code consistency checks. To fix this CI test, please run:
yaml-lint
npm
then install yaml-lint
(npm install -g yaml-lint
)yamllint $(find . -type f -name "*.yml" -o -name "*.yaml")
Once you push these changes the test should pass, and you can hide this comment :+1:
We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!
Thanks again for your contribution!
Please also test @TCLamnidis in addition to the review
Tests passed. All good <3
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 6779efc
+| ✅ 387 tests passed |+
#| ❔ 5 tests were ignored |#
!| ❗ 31 tests had warnings |!
Closes #733
Main changes: replaces lane with
0
after lane fastq merging, and pulls single string for seqtype ; both to remove (unstable) NXF arraybag objects beforejoin
Also includes: removal of old debugging dumps
Alternatively, to reduce possible downstream effects (and keep behaviour from previous versions), we could just do the flatten() or even remove via a
.map()
the two problematic meta fields from the two endorspy input channels...PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).