Closed jfy133 closed 1 year ago
master
branch :x:base
to dev
Hi @jfy133,
It looks like this pull-request is has been made against the nf-core/eager master
branch.
The master
branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master
are only allowed if they come from the nf-core/eager dev
branch.
You do not need to close this PR, you can change the target branch to dev
by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.
Thanks again for your contribution!
@meganemichel and @aidaanva please try this branch -r patch-multivcfanalyzer-readgroups
on your data both with and without running MultiVCFAnalyzer and check the VCF files look good (without MVA: include multiple samples in the VCF; with MVA: single samples in VCF so compatible with MVA)
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 415d05e
+| ✅ 386 tests passed |+
#| ❔ 5 tests were ignored |#
!| ❗ 32 tests had warnings |!
isnt the tool called AddOrReplaceReadGroups?
Tested patch and confirm that running with --run_multivcfanalyzer
triggers updating of read groups, while running without --run_multivcfanalyzer
produces unmodified vcfs.
I now remember why we had it in the first place :roll_eyes:
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).