search

nf-core / eager

A fully reproducible and state-of-the-art ancient DNA analysis pipeline
https://nf-co.re/eager
MIT License
134 stars 79 forks source link

Incorrect software version for GATK Unified Genotyper #950

Closed meganemichel closed 1 year ago

meganemichel commented 1 year ago

Description of the bug

In the software_versions.csv, the version for GATK UnifiedGenotyper is listed as vPicked rather than the correct version number.

jfy133 commented 1 year ago

I guess there is a faultly regex pattern.

For reference: gatk=3.5

But this will be working properly in eager3, so I prefer not to do a patch on eager2 for this (As it's minor) in preference for eager3 - but if we have to do a major bug fix then I'll include this

jfy133 commented 1 year ago

I'm a bit confused, I Can't replicate this. Will close for now... maybe it magically fixed itself?

image

jfy133 commented 1 year ago

Ah ok it is something about the EVA cluster specifically, and the hacks we have to do to make them work with java, so as it's an edge case I stand by my original comment of waiting for eager3 😬