Closed jfy133 closed 1 year ago
Current to do:
@nf-core-bot fix linting
Please rename mitchondrion
to mitochondrion_name
I vote mitochondrion_header
Next time: Continue updating modules.conf
so all output files after mappign include the reference name
Then official samplesheet (see testing/
) and then actual testing
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 3ee3d9a
+| ✅ 158 tests passed |+
!| ❗ 19 tests had warnings |!
Whoops edited your comment not quoting :facepalm:
- [ ] (optional) Add deduplication to be ran with test_multiref profile
That should run by default, no?
what's up with failing manual tests?
I wanted to test it failed correctly because they were incompatioble tc.
Whoops edited your comment not quoting 🤦
- [ ] (optional) Add deduplication to be ran with test_multiref profile
That should run by default, no?
Is this test profile implemented in the tests yet?
what's up with failing manual tests?
I wanted to test it failed correctly because they were incompatioble tc.
There was one marked with a question mark, where it didnt seem like expectation was a failure
Tested reference sheets
@nf-core-bot fix linting
I've made all the changes @TCLamnidis , however you and @scarlhoff's stupid HapMap poop-gen files have now broken the tests again...
ERROR ~ Invalid method invocation `call` with arguments: [[id:Mammoth_MT_Krause], /nf-core/test-datasets/eager/reference/Mammoth/Mammoth_MT_Krause.fasta, /home/runner/work/eager/eager/work/68/315f26b95b0aea12ecbd65f4320b86/Mammoth_MT_Krause.fasta.fai, /home/runner/work/eager/eager/work/c8/12f5e1a6486962f43ad873f4bc788a/Mammoth_MT_Krause.dict, /home/runner/work/eager/eager/work/ae/affedff2a287be10a59906aad52ca4/bwa, null, null, /home/runner/work/eager/eager/assets/angsd_resources/HapMapChrX.gz] (java.util.LinkedList) on _closure20 type
Following my previous notes to myself , there is a .map{
definition somewhere, where the HapMap position of a channel element is not given a variable name. However for teh life of me I cannot find where on earht this HapMap file is added to the reference indices.... so you guys need to find that and fix it, as this has come from you :grimacing: . Otherwise wierdly using the multiref CSV file (Rather than straight fasta), passes teh tests.
I've made all the changes @TCLamnidis , however you and @scarlhoff's stupid HapMap poop-gen files have now broken the tests again...
ERROR ~ Invalid method invocation `call` with arguments: [[id:Mammoth_MT_Krause], /nf-core/test-datasets/eager/reference/Mammoth/Mammoth_MT_Krause.fasta, /home/runner/work/eager/eager/work/68/315f26b95b0aea12ecbd65f4320b86/Mammoth_MT_Krause.fasta.fai, /home/runner/work/eager/eager/work/c8/12f5e1a6486962f43ad873f4bc788a/Mammoth_MT_Krause.dict, /home/runner/work/eager/eager/work/ae/affedff2a287be10a59906aad52ca4/bwa, null, null, /home/runner/work/eager/eager/assets/angsd_resources/HapMapChrX.gz] (java.util.LinkedList) on _closure20 type
Following my previous notes to myself , there is a
.map{
definition somewhere, where the HapMap position of a channel element is not given a variable name. However for teh life of me I cannot find where on earht this HapMap file is added to the reference indices.... so you guys need to find that and fix it, as this has come from you 😬 . Otherwise wierdly using the multiref CSV file (Rather than straight fasta), passes teh tests.
Should be fixed now, only needed to add the new reference sheet columns to the channel mapping adding a meta to the hapmap file. I also changed the test profile for angsd and mtnucratio CI tests to test_humanbam, so it will actually produce output. The hapmap will be properly integrated to the reference sheet in a separate PR
Adds ability to provide a TSV file listing multiple references and their correpsonding indicies etc.
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).