search

nf-core / exoseq

Please consider using/contributing to https://github.com/nf-core/sarek
http://nf-co.re
MIT License
16 stars 28 forks source link

Removed problematic local executor specification #25

Closed alneberg closed 6 years ago

alneberg commented 6 years ago

Related to https://github.com/nextflow-io/nextflow/issues/693#issuecomment-391792952 and https://github.com/nf-core/cookiecutter/issues/30

alneberg commented 6 years ago

@ewels, I think this PR is faulty? Feel free to close this one if you agree.

ewels commented 6 years ago

Faulty how? Looks good to me!

ewels commented 6 years ago

The tests are failing because the travis config hasn’t been set up yet (it’s blank).

alneberg commented 6 years ago

Ok, if you think it looks good, then I'm pleased! I just thought it was one of those other cases where there were no "script" defined so that it would actually make sense to force it to run locally?

pditommaso commented 6 years ago

In this case it's fine to have executor 'local' because the process execute groovy code, not an bash script. Removing the localexecutor it will print a warning message when running the workflow in a cluster/cloud.

ewels commented 6 years ago

Yes, I didn't read far enough down the diff to realise that it was an exec not a script. The process name has been updated in other repos to use a script and run as a regular process, so I think it's fine to remove it like this, as we'll almost certainly update it further in the future.

Thanks for the clarification though @pditommaso! 👍