search

nf-core / funcscan

(Meta-)genome screening for functional and natural product gene sequences
https://nf-co.re/funcscan
MIT License
74 stars 20 forks source link

deepBGC incorrect result directory #158

Closed Darcy220606 closed 1 year ago

Darcy220606 commented 1 year ago

Description of feature

deepBGC currently writes the files in parent directory with sample name and within that a subdir again with sample name and within that the output results example: ../results/bgc/deepbgc/Sample_1/Sample_1/files+evaluation dir

jfy133 commented 1 year ago

Hmmm, I don't get hat exactly:

image

But I see why this is now:

https://github.com/nf-core/modules/blob/5e34754d42cd2d5d248ca8673c0a53cdf5624905/modules/nf-core/deepbgc/pipeline/main.nf

the module is wrong, it should be updated to prefix rather than ${genome.baseName}/

@louperelo do you want to look into this or shoud I fix it?

louperelo commented 1 year ago

As you already detected the problem, please go on and fix it @jfy133

jfy133 commented 1 year ago

https://github.com/nf-core/modules/pull/2605