Closed jfy133 closed 6 months ago
nf-core lint
overall result: Passed :white_check_mark:Posted for pipeline commit d830fc0
+| ✅ 236 tests passed |+
And consider renaming
--contig_qc_lengththreshold
intocontig_qc_length
. I find it obvious that it is a threshold and would make it easier to write? ;)
I had that originally but I don't think it's very descriptive to what is actually happening. I wasn't happy with threshold either but I couldn't think of a better never...
Adds contig separation to stop crfash of antismash/gecco if contigs under required threshold.
theoreitcally Just need to update workflow diagram and ready to go.
Only thing design wise - should we future proof and instead set values per workflow type, rather than just long (for BGC) vs short?
For example: what if we add another screening for something else that requires 'super long' contigs? Downside is then we indeed start getting duplication of files basically