nf-core / hic

Analysis of Chromosome Conformation Capture data (Hi-C)
https://nf-co.re/hic
MIT License
81 stars 55 forks source link

sample name #115

Closed nservant closed 1 year ago

nservant commented 2 years ago

Issue with the sample names when we extract the prefix information

sample = prefix.toString() - ~/(_R1|_R2|_val_1|_val_2|_1|_2)/

The pipeline crashed at the MultiQC part, because the stats files do not have the same prefix

To reproduce the issue, use the following sample names ;

davidmasp commented 2 years ago

Hi, run into this problem as well (or similar). I forked it and tried to fix it a bit "randomly" as I am not super familiar with the pipeline.

Here is the last version which worked for me.

I am not sure if there is an easy way to test more strict configurations. I think my "fix" might break the option to split the fastqs.

nservant commented 1 year ago

fixed in DSL2, as the pipeline is now based on a sample sheet with a clear sample id