Closed nservant closed 1 year ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit f960b38
+| ✅ 157 tests passed |+
!| ❗ 1 tests had warnings |!
We should release this as 2.0! 🚀
agree for version 2.0
!
Should I did the changes on my own dev
branch, then, re-open a new PR to the nf-core-hic/dev
?
agree for version
2.0
! Should I did the changes on my owndev
branch, then, re-open a new PR to thenf-core-hic/dev
?
I think that's the proper way to do modifications ;-)
@drpatelh, @maxulysse, I created a new PR to bump v2.0.0 https://github.com/nf-core/hic/pull/145
@nservant regarding the
Argument of 'channel.from' method cannot be a channel object — Likely you can replace the use of 'channel.from' with the channel object itself
You'll have to replace channel.from
by channel.of
, cf https://github.com/nf-core/sarek/pull/906
Maxime (and perhaps others) have noted that the hic pipeline is generating the warning
WARN: A process with name 'BOWTIE2_ALIGN_TRIMMED' is defined more than once in module script: /home/runner/work/hic/hic/./workflows/../subworkflows/local/./hicpro_mapping.nf -- Make sure to not define the same function as process
This looks like a bug in Nextflow for which I have filed an issue (https://github.com/nextflow-io/nextflow/issues/3560). A workaround would be to ensure that both imports of the BOWTIE2_ALIGN
process are aliased to new names.
PR checklist
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).Ready for the next release of
nf-core-hic
. Changes include ;