non-coding sourmash compute

pranathivemuri commented 4 years ago

Many thanks to contributing to nf-core/kmermaid!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

[ ] PR is to dev rather than master
[ ] This comment contains a description of changes (with reason)
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/kmermaid branch on the nf-core/test-datasets repo
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Make sure your code lints (nf-core lint .).
[ ] Documentation in docs is updated
[ ] CHANGELOG.md is updated
[ ] README.md is updated

pranathivemuri commented 4 years ago

https://github.com/nf-core/kmermaid/blob/79af1c731c7a080a6223516a3e0d170021625f68/main.nf#L1377 - sourmash_sketches is set to concatenate both sketches obtained from nucleotide and peptide sequences and do you want it not do compare on peptide sequence? please let me know if I can understand correctly

olgabot commented 4 years ago

Please update the changelog and usage.md, thanks!

pranathivemuri commented 4 years ago

@olgabot please merge when you can