nf-core / kmermaid

k-mer similarity analysis pipeline
https://nf-co.re/kmermaid
MIT License
19 stars 12 forks source link

Fix file() issues for S3 outputs #90

Closed olgabot closed 3 years ago

olgabot commented 4 years ago

Updates/changes to kmermaid to make it amenable to running on many bams, not just .tar.gz files.

PR checklist

Learn more about contributing: https://github.com/nf-core/kmermaid/tree/master/.github/CONTRIBUTING.md

pranathivemuri commented 4 years ago

I don't see how the changes you made

  1. enabled nextflow tower
  2. working on many bams
  3. did you mean tenx_gz files?
olgabot commented 4 years ago

Hmm I think these changes are getting rid of the single bam2fasta run which used single_ksize and then changed new File to file so it can run on S3 more seamlessly. Without file, then a local folder called s3/path/to/outdir gets made and the pipeline output doesn't get saved

olgabot commented 4 years ago

I don't see how the changes you made

  1. enabled nextflow tower

I think I meant s3 instead.. sorry

  1. working on many bams

I think I meant the if params.bam section which errors out if you don't provide those other paramters

  1. did you mean tenx_gz files?

This is the .tar.gz files that are output by our implementation of the cellranger count pipeline for counting reads per cell from the 10X genomics output