Closed jmuhlich closed 6 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit fb4273e
+| ✅ 167 tests passed |+
!| ❗ 26 tests had warnings |!
I noticed the local lint failure on the images too. I just ran nf-core lint --fix
and it did update the images (minor text kerning change). I've committed that change here and we'll see if it passes.
Nope, with those updated images the CI lint check fails! I force-pushed the previous commit so all checks should be passing again.
I found some people in Slack who had the same inconsistency issues with nf-core lint and the logos. I submitted an issue with my findings: nf-core/tools#2893
I can't speak for the details of the groovy code, slowly getting into it, but in general I really like the subworkflows that check input and format output. It is much more intuitive, at least for me :). Great work @jmuhlich
I think the EditorConfig and Prettier tests were previously required but have been phased out with the new tools update, so they'll never be run here. I'll ask some nf-core folks how to proceed.
I can't speak for the details of the groovy code, slowly getting into it, but in general I really like the subworkflows that check input and format output. It is much more intuitive, at least for me :). Great work @jmuhlich
Thanks Jose! Those new subworkflows are all from the new nf-core tools release and template updates, so all credit to the tools team.
OK! Maxime adjusted our required checks to remove the stale ones, so we're good to go.
Resolved conflicts in automated PR.