Closed tillenglert closed 1 year ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit 2e513a1
+| ✅ 159 tests passed |+
!| ❗ 12 tests had warnings |!
@nf-core-bot fix linting
Some thoughts about the names:
subworkflow: INPUT_CHECK
-> maybe PROCESS_INPUT
(shorter, instead of PREPROCESSING_INPUT
)?
process: CHECK_SAMPLESHEET
-> CHECK_SAMPLESHEET_CREATE_TABLES
(instead of INPUT_TO_DATAMODEL
)? Not sure, I like it if the names are descriptive and like this it would become clear that it is an equivalent/extension to check_samplesheet
, but it's long. But I wouldn't use "datamodel".
what do you think?
@skrakau Could you have another look? :)
I restructured the preprocessing of the input samplesheet and renamed the corresponding processes. Therefore, template updates won't clash with our modules and it is a better fitting name (
INPUT_TO_DATAMODEL
) as the previously named processCHECK_SAMPLESHEET
was not only checking but creating the data model. The sub workflowINPUT_CHECK
was also renamed toPREPROCESSING_INPUT
. I'm open for suggestions in naming the process/subworkflow.Also I fixed some other things I stumbled over while developing.
Addresses: https://github.com/nf-core/metapep/issues/71
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).