search

nf-core / modules

Repository to host tool-specific module files for the Nextflow DSL2 community!
https://nf-co.re/modules
MIT License
280 stars 716 forks source link

Move from paths-filter #3808

Closed edmundmiller closed 8 months ago

edmundmiller commented 1 year ago

Have you checked the docs?

Description of the bug

It's served us well, but we're hitting API limits.

Maybe we're able to pass it an API key through a secret?

Example in https://github.com/nf-core/modules/pull/3807

Command used and terminal output

No response

Relevant files

No response

System information

No response

edmundmiller commented 1 year ago

https://github.com/dorny/paths-filter/issues/108 https://github.com/dorny/paths-filter/issues/73

Hmm I don't think it's paths-filter, I think we're hitting it somewhere else, and I think it's just the first thing to hit the API...

frouioui commented 8 months ago

Hello @edmundmiller, using https://github.com/dorny/paths-filter/pull/133 I have been to alleviate the API rate limit issues we were hitting on https://github.com/vitessio/vitess.

Here is the PR that uses https://github.com/dorny/paths-filter/pull/133 in vitess: https://github.com/vitessio/vitess/pull/10106

cc @mirpedrol

edmundmiller commented 8 months ago

@frouioui Hey thanks for reaching out! I think @mirpedrol solved it in #4202

dorny commented 8 months ago

FYI: the @frouioui fix has been merged in https://github.com/dorny/paths-filter/pull/133 and included in v3.0.1 release.