nf-core / modules

Repository to host tool-specific module files for the Nextflow DSL2 community!
https://nf-co.re/modules
MIT License
258 stars 651 forks source link

Pass annotation files to last-dotplot #5885

Closed charles-plessy closed 4 days ago

charles-plessy commented 5 days ago

This adds the capacity to overlay annotations to the dot plots. In the pairgenomealign pipeline, we will use it to indicate genomic regions containing N stretches that typically mark contig boundaries in scaffold assemblies, like the pink lines in the following example:

image

Details

The annotation of the target (plotted horizontally) genome is passed as a new channel.

The annotation of the query (plotted vertically) genome is passed as a new component of the first channel.

This is because this module typically loops on a list of alignments of various query genomes (from samplesheet) to a single target genome.

The annotation files are called annot_a and annot_b because they are passed to the -a and -b arguments of last-dotplot.

PR checklist

Closes #XXX

charles-plessy commented 4 days ago

Good to know, thank you. Do I need to mark the discussion resolved or is it enough that the file was changed in a newer commit ?

SPPearce commented 4 days ago

Good to know, thank you. Do I need to mark the discussion resolved or is it enough that the file was changed in a newer commit ?

As an author, I generally mark the discussions as resolved once I have addressed them, assuming that they are just minor fixes like these. If I want to continue the discussion then I don't.