nf-core / modules

Repository to host tool-specific module files for the Nextflow DSL2 community!
https://nf-co.re/modules
MIT License
284 stars 722 forks source link

Add pre filter and shard counting step #7025

Open mashehu opened 6 days ago

sateeshperi commented 6 days ago

in gpu-tests.yml, the trigger is on PR to master and those paths. should we include subworkflows too that have gpu tests ?

  pull_request:
    branches: [master]
    paths:
      - ".github/workflows/gpu-tests.yml"
      - "modules/nf-core/parabricks/**"
mashehu commented 6 days ago

I wouldn't at special paths just all modules and subworkflows. Then the filter step will take care of only picking up GPU tests

sateeshperi commented 6 days ago

why aren't some tests not launching ?

mashehu commented 5 days ago

they are not stalled, they are just required, but never launched (because we don't have anything to test). so we need to remove them from the ruleset and add a step which confirms the passing of all tests (either that they ran successfully or that they didn't have to be run)