nf-core / modules

Repository to host tool-specific module files for the Nextflow DSL2 community!
https://nf-co.re/modules
MIT License
284 stars 721 forks source link

New module: regtools junction extract #7033

Closed abartlett004 closed 2 days ago

abartlett004 commented 3 days ago

PR checklist

New module for regtools junction extract

Closes #7032

lpantano commented 2 days ago

@mashehu, can you take a quick look in case we are missing something? thanks!

SPPearce commented 2 days ago

Linting fails: nf-core modules lint regtools/junctionsextract

And it didn't run at all?

SPPearce commented 2 days ago

@edmundmiller, while you are here can you check why nf-core modules lint didn't notice the lack of versions (or wasn't ran at all)?

edmundmiller commented 2 days ago

Just started looking into this because it should've triggered the wave CI, but it didn't 🙃

Ah, it's coming from a fork, and that's why.

lpantano commented 2 days ago

@SPPearce, do you have any other comment?

edmundmiller commented 2 days ago

Updated the regex and tested the versions.

Gonna skip the CI on this one, should be fixed in #7043

SPPearce commented 2 days ago

@SPPearce, do you have any other comment?

No, happy now (although as Edmund had approved that was sufficient)