BEDTOOLS_INTERSECT_FILTER is not invoked before accessing the output attribute in release version

nf-core / nascent

Nascent Transcription Processing Pipeline

https://nf-co.re/nascent

MIT License

18 stars 10 forks source link

BEDTOOLS_INTERSECT_FILTER is not invoked before accessing the output attribute in release version #105

Closed jianhong closed 1 year ago

jianhong commented 1 year ago

Description of the bug

BEDTOOLS_INTERSECT_FILTER is not invoked before accessing the output attribute in script subworkflows/local/transcript_identification.nf at line 66 when params.filter_bed is not defined or set to false.

Fix:

remove codes from line 64 to 68 in file transcript_identification.nf

Command used and terminal output

No response

Relevant files

No response

System information

No response

edmundmiller commented 1 year ago

Hello! Thanks for reporting. I have a hunch this was fixed in https://github.com/nf-core/nascent/pull/94, but I don't have enough information about what command you ran.

jianhong commented 1 year ago

@Emiller88 I see you fixed it in dev version. What I tried is release version. Anyway, good to see it already fixed.

edmundmiller commented 1 year ago

Awesome, feel free to reopen if it doesn't work with -r dev!

Just been hung up in review limbo for a bit.