Open edmundmiller opened 3 months ago
nf-core lint
overall result: Passed :white_check_mark: :warning:Posted for pipeline commit d1c51a0
+| ✅ 199 tests passed |+
#| ❔ 4 tests were ignored |#
!| ❗ 2 tests had warnings |!
I ran the pipeline dev
version with samplesheet:
sample,fastq_1,fastq_2
REP1,./sortmerna/SRR1693611/out/other.fq.gz,
REP2,./sortmerna/SRR1693612/out/other.fq.gz,
The sample names are different in this case, since I cannot run latest version with the same sample name. It failed with:
ERROR ~ Error executing process > 'NFCORE_NASCENT:NASCENT:TRANSCRIPT_INDENTIFICATION:GROHMM:GROHMM_PARAMETERTUNING (REP2)'
Caused by:
No such variable: bam -- Check script '/users/dmitry.mylarshchikov/.nextflow/assets/nf-core/nascent/./workflows/../subworkflows/local/./grohmm/../../../modules/local/grohmm/parametertuning/main.nf' at line: 26
Source block:
def args = task.ext.args ?: ''
def prefix = task.ext.prefix ?: "${meta.id}"
"""
parameter_tuning.R \\
--bam_file ${bam} \\
--tuning_file ${tune_parameter_file} \\
--outprefix ${prefix} \\
--gtf $gtf \\
--outdir ./ \\
--cores $task.cpus \\
$args
cat <<-END_VERSIONS > versions.yml
"${task.process}":
r-base: \$(echo \$(R --version 2>&1) | sed 's/^.*R version //; s/ .*\$//')
bioconductor-grohmm: \$(Rscript -e "library(groHMM); cat(as.character(packageVersion('groHMM')))")
END_VERSIONS
"""
Okay, that's out of bounds 😆
sample,fastq_1,fastq_2
replicate1,./sortmerna/SRR1693611/out/other.fq.gz,
replicate2,./sortmerna/SRR1693612/out/other.fq.gz,
Maybe?
Might be able to improve the error handling earlier in the pipeline with nf-schema to abort if is a name is just REP1
I renamed samples to "replicate1" and "replicate2", and I still get the same error from GROHMM_PARAMETERTUNING.
Closes #158
@dmitrymyl just made a test case for now, it passed so I'm not sure where the bug is.
Could you try your full run on the
dev
branch?